Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selection.js #6167

Merged
merged 4 commits into from
Jun 6, 2017
Merged

Update selection.js #6167

merged 4 commits into from
Jun 6, 2017

Conversation

nbulusanjr
Copy link
Contributor

Select childrens of row group.

Fix for Issue on selecting row header childrens are not selected #6160

Select childrens of row group
@@ -725,6 +725,11 @@
else if (evt.ctrlKey || evt.metaKey) {
uiGridSelectionService.toggleRowSelection(self, row, evt, self.options.multiSelect, self.options.noUnselect);
}
else if (row.groupHeader) {
for (var i = 0; i < row.treeNode.children.length; i++) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the indentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already fixed the indentation.

@mportuga mportuga merged commit 21819c5 into angular-ui:master Jun 6, 2017
vishalnarewade pushed a commit to vishalnarewade/ui-grid that referenced this pull request Nov 6, 2017
* Update selection.js

Select childrens of row group

* format indentation

* Change scrolling from scroll to auto.

* Update test script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants