Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Commit

Permalink
fix(positioning): stop flicker when closed
Browse files Browse the repository at this point in the history
When the dropdown is in an up position and it is closed we were
removing the positioning before hiding it which caused a flicker
while it moved down to it's natural bottom position. This change
sets the opacity to 0 before resetting the positioning style
attributes.
  • Loading branch information
darrinholst committed May 16, 2016
1 parent aa90dd8 commit ca4d09e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/uiSelectDirective.js
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,7 @@ uis.directive('uiSelect',
}

// Reset the position of the dropdown.
dropdown[0].style.opacity = 0;
dropdown[0].style.position = '';
dropdown[0].style.top = '';
element.removeClass(directionUpClassName);
Expand Down

0 comments on commit ca4d09e

Please sign in to comment.