This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
ui-select-multiple choices are not refreshed after a ngModel update #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronroberson
added a commit
that referenced
this pull request
Mar 23, 2016
…hange fix(uiSelectMultipleDirective): refresh choices upon selection change Closes #1243
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The watcher on ngModel.$modelValue is called before ngModel.$render. It means that $select.refreshItems() is called before $select.selected is updated (called through $selectMultiple.refreshComponent()).
This naive fix ensures that the component is refreshed after a model update. I suppose that there is a better way to do this by refactoring the ngModel event handling ($render is not doing any rendering, so that's an hint), but I don't have enough time to dig into what would be proper.
For those who would want an external fix, it is possible to work around the issue by manually updating $select.selected, e.g. angular.element('#myUISelectMultiple').controller('uiSelect').selected = myNewNgModelValue;
This should be called before the digest following the ngModel value is changed.