Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

ui-select-multiple choices are not refreshed after a ngModel update #1243

Closed
wants to merge 1 commit into from

Conversation

Telem
Copy link

@Telem Telem commented Oct 12, 2015

The watcher on ngModel.$modelValue is called before ngModel.$render. It means that $select.refreshItems() is called before $select.selected is updated (called through $selectMultiple.refreshComponent()).

This naive fix ensures that the component is refreshed after a model update. I suppose that there is a better way to do this by refactoring the ngModel event handling ($render is not doing any rendering, so that's an hint), but I don't have enough time to dig into what would be proper.

For those who would want an external fix, it is possible to work around the issue by manually updating $select.selected, e.g. angular.element('#myUISelectMultiple').controller('uiSelect').selected = myNewNgModelValue;
This should be called before the digest following the ngModel value is changed.

aaronroberson added a commit that referenced this pull request Mar 23, 2016
…hange

fix(uiSelectMultipleDirective): refresh choices upon selection change

Closes #1243
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant