This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Bug Fix: Selected items should not be removed when they are found to be invalid #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing scenario: ui-select configuration: -tagging -async with refresh delay problem code flow: 1) user enters tag text and immediately accepts the new tag(s) (with tab or the like), such that the tag is created before the refresh delay expires 2) a validator determines that the tag is invalid, and sets the model value of the ui-select instance to undefined. At this point the view value still shows the invalid value. 3) refresh is triggered after the delay, and updates the items list on the uiSelectCtrl 4) the item watcher sees the change and causes the view value to be updated from the model value, in order to reflect the data in the fresh items 5) since the model value is undefined until the invalid condition is resolved, the formatters run and create an empty view value, erasing the tagged item(s) - the user does not have an opportunity to resolve the invalid condition, their data is just erased. solution: do not update the view value on items refresh, when the model value is undefined
|
👍 |
|
This pull request should resolve this issue: #981 |
|
This just needs squashing, but LGTM |
fcaballero
pushed a commit
to fcaballero/ui-select
that referenced
this pull request
Apr 17, 2016
- Prevent accidental removal of a tagged item that subsequently becomes invalid Closes angular-ui#1359
fcaballero
pushed a commit
to fcaballero/ui-select
that referenced
this pull request
Apr 25, 2016
- Prevent accidental removal of a tagged item that subsequently becomes invalid Closes angular-ui#1359
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tagged item was getting removed accidentally in the following scenario:
ui-select configuration:
problem code flow:
4. The item watcher sees the change and causes the view value to be updated from the model value, in order to reflect the data in the fresh items.
solution:
Do not update the view value on items refresh, when the model value is undefined