Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

hide clear button if disabled #1388

Merged
merged 1 commit into from
Apr 7, 2016
Merged

Conversation

Raytray
Copy link
Contributor

@Raytray Raytray commented Jan 15, 2016

This addresses this issue: #980

Clear button shown on disabled select

This will hide the clear button if $select.disabled is true.

@user378230
Copy link
Contributor

@Raytray Can you update this to just be a !$select.disabled? It's a bit verbose at the moment, unless it was intentional?

@Raytray
Copy link
Contributor Author

Raytray commented Apr 7, 2016

It was intentional, if I remember correctly, it is because of other
falsy/truthy values.

-Raymond Tang
On Apr 7, 2016 12:20 PM, "user378230" notifications@github.com wrote:

@Raytray https://github.com/Raytray Can you update this to just be a
!$select.disabled? It's a bit verbose at the moment, unless it was
intentional?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1388 (comment)

@user378230
Copy link
Contributor

Ok thanks 👍

@user378230 user378230 merged commit fe0c0c1 into angular-ui:master Apr 7, 2016
fcaballero pushed a commit to fcaballero/ui-select that referenced this pull request Apr 17, 2016
hide clear button if ui-select is disabled

Closes angular-ui#1388 and angular-ui#980
fcaballero pushed a commit to fcaballero/ui-select that referenced this pull request Apr 25, 2016
hide clear button if ui-select is disabled

Closes angular-ui#1388 and angular-ui#980
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants