Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Fix input box hidding #595

Closed
wants to merge 1 commit into from

Conversation

gen4sp
Copy link
Contributor

@gen4sp gen4sp commented Jan 20, 2015

#453
Input box is hidden with search-enabled="false" with Bootstrap them

fixed

@austin-sa-wang
Copy link

Could we get this merged for those who are waiting on issue #453?

@readme42
Copy link

This works, merge it please!

@wesleycho
Copy link
Contributor

@user378230 may be worth merging this via curl https://patch-diff.githubusercontent.com/raw/angular-ui/ui-select/pull/595.patch | git am -3 and resolving any conflicts/modifying the commit message locally via git commit --amend. This modification looks like it needs to be on all templates.

@wesleycho
Copy link
Contributor

Thoughts on this @user378230 ? I can merge this locally and fix up the conflict in this instance fairly easily if desired.

@user378230
Copy link
Contributor

@wesleycho I'm not a 100% sure what it does, its a minor change though - merge for now, we can revert if need be.

For reference #1543 has the same change.

@wesleycho wesleycho closed this in 83132b0 Apr 6, 2016
@CoperNick8
Copy link

This fix should also be applied to dist/select.js file in this line
$templateCache.put("bootstrap/match.tpl.html","<div class=\"ui-select-match\" ng-hide=\"$select.open\" ...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants