This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
fix for #875, properly working tab in firefox #898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcaballero
pushed a commit
to fcaballero/ui-select
that referenced
this pull request
Apr 17, 2016
- Explicitly disallow focusing of list, mainly fixes behavior in Firefox Closes angular-ui#898
fcaballero
pushed a commit
to fcaballero/ui-select
that referenced
this pull request
Apr 25, 2016
- Explicitly disallow focusing of list, mainly fixes behavior in Firefox Closes angular-ui#898
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #875. Tab in firefox was not working properly because in some cases the
tag in the select2 theme gets the focus. Explicitly putting tabindex="-1" on the tag fixes the bug.
I do not understand how it is possible that
gets the focus anyhow, thus with this fix I might have missed the underlying cause.