This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Update search inputs type #991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruipenso
force-pushed
the
enhancement/input-search
branch
from
a5e333c
to
2a97a45
Compare
fcaballero
pushed a commit
to fcaballero/ui-select
that referenced
this pull request
Apr 17, 2016
- Change inputs to `type="search"` - Change to `autocomplete="off"` as per HTML spec Closes angular-ui#991
fcaballero
pushed a commit
to fcaballero/ui-select
that referenced
this pull request
Apr 25, 2016
- Change inputs to `type="search"` - Change to `autocomplete="off"` as per HTML spec Closes angular-ui#991
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome does not support the
autocomplete="off"parameter on<input type="text">fields.This PRs implements the suggested workaround by changing the type to
search.I also believe that this makes more sense semantically since the input is being used for filtering the results.