From 3e359da8dfdbfdb99be13f5c52a7e429c106d4ad Mon Sep 17 00:00:00 2001 From: Alan Agius Date: Sun, 23 Jun 2024 13:04:09 +0000 Subject: [PATCH] fix(@angular/build): address rxjs undefined issues during SSR prebundling Replacing the paths to ESM in Vite can cause prebundling to fail in some cases, resulting in errors similar to the following: ``` 12:55:12 PM [vite] Error when evaluating SSR module /chunk-CHB4JJIP.mjs: |- TypeError: Cannot read properties of undefined (reading 'Subject') at eval (//src/app/shared/snackbar/snackbar.service.ts:2:25) at async instantiateModule (file:////node_modules/vite/dist/node/chunks/dep-BcXSligG.js:53408:5) 12:55:12 PM [vite] Error when evaluating SSR module /chunk-GQZ5BKXC.mjs: |- TypeError: Cannot read properties of undefined (reading 'Subject') at eval (//src/app/shared/snackbar/snackbar.service.ts:2:25) at async instantiateModule (file:////node_modules/vite/dist/node/chunks/dep-BcXSligG.js:53408:5) ``` Closes: #27907 --- .../angular/build/src/builders/dev-server/vite-server.ts | 5 ----- 1 file changed, 5 deletions(-) diff --git a/packages/angular/build/src/builders/dev-server/vite-server.ts b/packages/angular/build/src/builders/dev-server/vite-server.ts index 737bd0d95ec8..dc76cbda3a72 100644 --- a/packages/angular/build/src/builders/dev-server/vite-server.ts +++ b/packages/angular/build/src/builders/dev-server/vite-server.ts @@ -25,7 +25,6 @@ import { BuildOutputFileType, type ExternalResultMetadata, JavaScriptTransformer, - createRxjsEsmResolutionPlugin, getFeatureSupport, getSupportedBrowsers, isZonelessApp, @@ -659,10 +658,6 @@ function getDepOptimizationConfig({ }, ]; - if (ssr) { - plugins.unshift(createRxjsEsmResolutionPlugin() as ViteEsBuildPlugin); - } - return { // Exclude any explicitly defined dependencies (currently build defined externals) exclude,