Skip to content

Commit

Permalink
fix(@angular/cli): adds language to index.html for accessibility
Browse files Browse the repository at this point in the history
  • Loading branch information
@dave11mj @sumitarora
dave11mj authored and sumitarora committed May 15, 2017
1 parent 4f48be0 commit cfe60b5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/@angular/cli/blueprints/ng/files/__path__/index.html
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!doctype html>
<html>
<html lang="en">
<head>
<meta charset="utf-8">
<title><%= jsComponentName %></title>
Expand Down

1 comment on commit cfe60b5

@cyrilletuzi
Copy link
Contributor

@cyrilletuzi cyrilletuzi commented on cfe60b5 May 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it come with a new option for ng new to choose the language ? It doesn't feel right English is enforced...

Of course there is just to change the index.html, and it's a quick change. But as the goal of the CLI is to produce ready-to-use files, and as most people won't check and change those static files, it seems quite adventurous to me.

Please sign in to comment.