Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows ng cli removes EOL and EOF from package.json #23587

Closed
jayvdb opened this issue Jul 18, 2022 · 2 comments
Closed

Windows ng cli removes EOL and EOF from package.json #23587

jayvdb opened this issue Jul 18, 2022 · 2 comments

Comments

@jayvdb
Copy link

jayvdb commented Jul 18, 2022

Which @angular/* package(s) are the source of the bug?

compiler-cli

Is this a regression?

No

Description

On Windows, and using git config core.autocrlf=true, when I run ng update @angular/cli or similar , package.json is edited and the trailing EOL at EOF is removed.

I have encountered this with ng update @angular/cli and ng add @angular/material so far.

@@ -38,4 +38,4 @@
     "karma-jasmine-html-reporter": "~1.7.0",
     "typescript": "~4.6.2"
   }
-}
+}
\ No newline at end of file

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

No response

Please provide the environment you discovered this bug in (run ng version)

Angular CLI: 14.0.6
Node: 16.16.0
Package Manager: npm 8.11.0
OS: win32 x64

Angular: 14.0.6
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1400.6
@angular-devkit/build-angular   14.0.6
@angular-devkit/core            14.0.6
@angular-devkit/schematics      14.0.6
@angular/cdk                    14.0.5
@angular/material               14.0.5
@schematics/angular             14.0.6
rxjs                            7.5.5
typescript                      4.6.4


### Anything else?

_No response_
@JoostK JoostK transferred this issue from angular/angular Jul 18, 2022
@alan-agius4
Copy link
Collaborator

Duplicate of #11744

@alan-agius4 alan-agius4 marked this as a duplicate of #11744 Jul 18, 2022
@alan-agius4 alan-agius4 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants