Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@angular/cli): Fix filtering files on completion #4972

Closed
wants to merge 2 commits into from
Closed

fix(@angular/cli): Fix filtering files on completion #4972

wants to merge 2 commits into from

Conversation

comewalk
Copy link
Contributor

This PR fixes #4664. It looks like the cause related to #4251.

@comewalk comewalk mentioned this pull request Feb 24, 2017
Closed
Meligy
Meligy suggested changes Feb 26, 2017
View reviewed changes
Copy link
Contributor

@Meligy Meligy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just like how help works.

Can you add a test for this as well? It would be a copy-paste from the help test.

@comewalk
Copy link
Contributor Author

@Meligy Thank you for your suggestion. I added a test for completion. Could you review this?

Meligy
Meligy approved these changes Feb 27, 2017
View reviewed changes
Copy link
Contributor

@Meligy Meligy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Thanks :)

@comewalk comewalk mentioned this pull request Mar 7, 2017
Closed
@filipesilva filipesilva mentioned this pull request Mar 7, 2017
Closed
@filipesilva
Copy link
Contributor

Thanks for fixing this @comewalk!

asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
@comewalk
fix(@angular/cli): Fix filtering files on completion
8b37217 
Fix angular#4664
Close angular#4972
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@filipesilva filipesilva filipesilva approved these changes

@Meligy Meligy Meligy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ng completion not working (Error: Cannot find module './build.d')
4 participants
@comewalk @filipesilva @Meligy @googlebot