-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@angular/cli): removes redundant rules from tslint.json #5783
fix(@angular/cli): removes redundant rules from tslint.json #5783
Conversation
Could you explain more how these rules were redundant? |
02e0656
to
59aef3f
Compare
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
59aef3f
to
03234d8
Compare
CLAs look good, thanks! |
@hansl sorry about the hiccup while trying to update the commit, I'll update the issue #5755 with additional testing instructions. But the tldr; is if you create two
The linter returns valid. As mentioned in the docs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this PR, I read through the original issue and think it's solid.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #5755