ci: fix poll test on circleci #6959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Aug 9, 2017
We add either `src/` or `src/$$_gendir/` directories as the lazy route resource, which causes rebuilds whenever anything changes there. Setting a resource doesn't actually seem to be necessary, I did a few local tests and lazy routes still seem to be added and updated correctly. @Brocco this should also fix your local failing poll test. Fix angular#6238 Close angular#6959
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Aug 10, 2017
We add either `src/` or `src/$$_gendir/` directories as the lazy route resource, which causes rebuilds whenever anything changes there. This PR makes it always use the `src/$$_gendir/` special directory. @Brocco this should also fix your local failing poll test. Fix angular#6238 Close angular#6959
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Aug 10, 2017
We add either `src/` or `src/$$_gendir/` directories as the lazy route resource, which causes rebuilds whenever anything changes there. This PR makes it always use the `src/$$_gendir/` special directory. @Brocco this should also fix your local failing poll test. Fix angular#6238 Close angular#6959
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this pull request
Apr 23, 2018
We add either `src/` or `src/$$_gendir/` directories as the lazy route resource, which causes rebuilds whenever anything changes there. This PR makes it always use the `src/$$_gendir/` special directory. @Brocco this should also fix your local failing poll test. Fix angular#6238 Close angular#6959
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.