Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support babel-loader #8045

Closed
cuongqle opened this issue Oct 13, 2017 · 2 comments
Closed

Missing support babel-loader #8045

cuongqle opened this issue Oct 13, 2017 · 2 comments

Comments

@cuongqle
Copy link

cuongqle commented Oct 13, 2017

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [x] feature request

Versions.

Repro steps.

ES6 code with spread operator
For example:
case REQUEST_GUIDE_FULFILLED:
| return {
| ...filterGuideData(action.guide),
| isLoaded: true,
| }

Exception thrown:
Module parse failed: C:\workspace\showhowAdmin\platform\node_modules\source-map-loader\index.js!C:\workspace\showhowAdmin\platform\showhow-admin\app\player\redux\reducers\domain\guide.js Unexpected token (10:6)
You may need an appropriate loader to handle this file type.

The log given by the failure.

Desired functionality.

Module parse failed: C:\workspace\showhowAdmin\platform\node_modules\source-map-loader\index.js!C:\workspace\showhowAdmin\platform\showhow-admin\app\player\redux\reducers\domain\guide.js Unexpected token (10:6)
You may need an appropriate loader to handle this file type.
| case REQUEST_GUIDE_FULFILLED:
| return {
| ...filterGuideData(action.guide),
| isLoaded: true,
| }

Mention any other details that might be useful.

In @angular/cli/modles/webpack-configs/common.ts, if i have a small modify by adding babel-loader rule into 'module' section:
{ test: /.(js|ts)$/, loader: "babel-loader", exclude: [nodeModules] }
then it work fine.

@filipesilva
Copy link
Contributor

We do not support transpiling javascript ES2015 code down to ES5 code by design. If you want to use babel to add custom ES2015 code, you will have to eject.

We have support for ES2015 targets without transpiling code down to ES5 in #7610. The resulting bundle will be contain ES2015 code.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants