fix(build): fix broken sourcemaps #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,11 +7,11 @@ module.exports = function(defaults) { | |||
| vendorNpmFiles: [ | |||
| 'systemjs/dist/system-polyfills.js', | |||
| 'systemjs/dist/system.src.js', | |||
| 'zone.js/dist/*.js', | |||
| 'zone.js/dist/**/*.*', | |||
There was a problem hiding this comment.
Thought it would be better because of the sourcemaps. Maybe copying js and js.map might be enough though.
filipesilva
force-pushed
the
fix-sourcemaps
branch
from
3aab95e
to
2376a68
Compare
|
@hansl can you review again please? |
|
Okay that makes more sense :) LGTM. |
|
Can a release get cut with this change so people not running on master can get it? |
This was referenced Jun 1, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of SystemJS fixed their support for sourcemaps, which caused our production builds to fail since our source maps weren't being generated/copied properly down the build pipeline.
This PR fixes that. Also closes #829.