From c1533ef5762199bea18d3bf3bcba7fcf89272931 Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Fri, 11 May 2012 23:56:37 -0700 Subject: [PATCH] fix($location): support urls with any protocol The url used for location parsing was quite strict and did not support custom url schemes like "chrome-extension://". With this change the only requirement for scheme is that it doesn't contain ":" character. --- src/ng/location.js | 2 +- test/ng/locationSpec.js | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/ng/location.js b/src/ng/location.js index 575feb7e1db5..6d38d1acf3ff 100644 --- a/src/ng/location.js +++ b/src/ng/location.js @@ -1,6 +1,6 @@ 'use strict'; -var URL_MATCH = /^(file|ftp|http|https):\/\/(\w+:{0,1}\w*@)?([\w\.-]*)(:([0-9]+))?(\/[^\?#]*)?(\?([^#]*))?(#(.*))?$/, +var URL_MATCH = /^([^:]+):\/\/(\w+:{0,1}\w*@)?([\w\.-]*)(:([0-9]+))?(\/[^\?#]*)?(\?([^#]*))?(#(.*))?$/, PATH_MATCH = /^([^\?#]*)?(\?([^#]*))?(#(.*))?$/, HASH_MATCH = PATH_MATCH, DEFAULT_PORTS = {'http': 80, 'https': 443, 'ftp': 21}; diff --git a/test/ng/locationSpec.js b/test/ng/locationSpec.js index 648fa42da5d4..b866b1e3da7d 100644 --- a/test/ng/locationSpec.js +++ b/test/ng/locationSpec.js @@ -632,6 +632,17 @@ describe('$location', function() { expect(match[10]).toBe('?book=moby'); }); + + + it('should parse chrome extension urls', function() { + var match = URL_MATCH.exec('chrome-extension://jjcldkdmokihdaomalanmlohibnoplog/index.html?foo#bar'); + + expect(match[1]).toBe('chrome-extension'); + expect(match[3]).toBe('jjcldkdmokihdaomalanmlohibnoplog'); + expect(match[6]).toBe('/index.html'); + expect(match[8]).toBe('foo'); + expect(match[10]).toBe('bar'); + }); });