Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ngClass on ngView is not in sync since 1.4.0-rc.0 #12080

Open
m4r71n opened this issue Jun 10, 2015 · 9 comments
Open

ngClass on ngView is not in sync since 1.4.0-rc.0 #12080

m4r71n opened this issue Jun 10, 2015 · 9 comments

Comments

@m4r71n
Copy link

m4r71n commented Jun 10, 2015

Working example with 1.4.0-beta.6: http://plnkr.co/edit/aBcSTUO8Et17Y8MSWNJL?p=preview
2015-06-10_221405
Also working with 1.3.16: http://plnkr.co/edit/ntFbY3UAloinduesYArq?p=preview

Broken example with 1.4.0-rc.0: http://plnkr.co/edit/22mLv7fXesMVXfEwX6Yt?p=preview
2015-06-10_221455
Also broken with 1.4.1: http://plnkr.co/edit/HBKVKqSLamxCR654QKrs?p=preview

I'm not sure if this is a bug or if I need to change something because of c8700f0?

@Narretz
Copy link
Contributor

Narretz commented Jun 16, 2015

What exactly is the problem? Do your animations not work anymore?
I cannot say with 100% certainty that the first example is correct, because I am not sure if the view animations are supposed to happen exactly at the same time.

@Narretz
Copy link
Contributor

Narretz commented Jun 16, 2015

Have you tried with 1.4.1?

@m4r71n
Copy link
Author

m4r71n commented Jun 17, 2015

I've updated the examples. With 1.3.16 and 1.4.0-beta.6 both ngViews slide at the same time in the same direction. With 1.4.0-rc.0 and 1.4.1 they sometimes crossover or slide away from each other.
By clicking the buttons in this order you can see the difference: 2,3,2,1,2

@matsko
Copy link
Contributor

matsko commented Jun 29, 2015

There are two bugs that exist here:

  1. There is an issue with ngClass in 1.4.x
  2. With the way that ngView works it destroys the scope first and then animates so the classes on the element don't get picked up in time.

I will aim to have both issues fixed in 1.4.2.

@matsko matsko self-assigned this Jun 29, 2015
@matsko
Copy link
Contributor

matsko commented Jul 17, 2015

Alright so this isn't an issue with ngClass (I tested this against #12248 and it didn't fix it). So it looks like it is number 2 on the list.

@Narretz Narretz modified the milestones: 1.4.5, Purgatory Aug 3, 2015
@Narretz
Copy link
Contributor

Narretz commented Aug 3, 2015

@matsko The problem still repdroduces in the current snapshot.

@Narretz Narretz modified the milestones: 1.4.5, 1.4.6 Aug 31, 2015
@petebacondarwin petebacondarwin modified the milestones: 1.4.6, 1.4.7 Sep 17, 2015
@Narretz
Copy link
Contributor

Narretz commented Sep 23, 2015

Still broken in 1.4.6 :(

@alexlamsl
Copy link

Applying a quick hack around $animate.{add,remove}Class() which performs the class manipulation before the proper queuing seems to solve the issue visually:

http://plnkr.co/edit/f7rjvA2waeVGPSWyAoor?p=preview

@matsko
Copy link
Contributor

matsko commented Sep 24, 2015

I am aware of this issue and I will have a look at it tomorrow. Sorry for the delays and thank you for keeping this issue going.

@Narretz Narretz modified the milestones: 1.4.7, 1.4.8 Oct 1, 2015
@Narretz Narretz modified the milestones: 1.4.8, 1.4.9 Nov 26, 2015
@petebacondarwin petebacondarwin modified the milestones: 1.4.9, 1.4.10 Jan 21, 2016
@petebacondarwin petebacondarwin modified the milestones: 1.4.10, 1.5.1 Jan 28, 2016
@Narretz Narretz modified the milestones: 1.5.1, 1.5.x Feb 15, 2016
@Narretz Narretz modified the milestones: 1.5.x, 1.6.x Mar 31, 2017
@Narretz Narretz modified the milestones: 1.6.x, 1.7.x Apr 12, 2018
@petebacondarwin petebacondarwin modified the milestones: 1.7.x, 1.7.x - won't fix May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants