This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile): remove redundant attr.specified #3231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attr.specified is deprecated in Gecko 7.0 and creates unwanted warnings on FireFox. It seems that modern browsers, but possibly not IE, only provide specified attributes when calling element.getAttributes() and so removing this is unlikely to break applications. See https://developer.mozilla.org/en-US/docs/Web/API/Attr and http://msdn.microsoft.com/en-us/library/ie/ms534637(v=vs.85).aspx Closes angular#2160
|
I believe that we had to put this in for IE8. Can you verify that this doesn't break IE8? If it doesn't go ahead and merge. |
|
Doesn't break the CI build for IE8: http://ci.angularjs.org/job/angular.js-pete/258/console |
|
can we merge this? |
|
based on git annotate I figured out that this was for ie7 |
|
I have a better fix: c915b38647c023eb0d319d899166526ee2fa14ec we officially don't support IE7 but since this code is there specifically for ie7 already I'm going to at least make it more obvious and avoid the impact on real browser. |
btford
pushed a commit
to btford/angular.js
that referenced
this pull request
Aug 12, 2013
the specified attribute is depricated and creates warnings in Firefox Closes angular#3231 Closes angular#2160
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attr.specified is deprecated in Gecko 7.0 and creates unwanted
warnings on FireFox. It seems that modern browsers, but possibly not
IE, only provide specified attributes when calling element.getAttributes()
and so removing this is unlikely to break applications.
See https://developer.mozilla.org/en-US/docs/Web/API/Attr and
http://msdn.microsoft.com/en-us/library/ie/ms534637(v=vs.85).aspx
Closes #2160