Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(jqLite): support space-seperated events in off #3256

Closed
wants to merge 1 commit into from
Closed

fix(jqLite): support space-seperated events in off #3256

wants to merge 1 commit into from

Conversation

ajoslin
Copy link
Contributor

@ajoslin ajoslin commented Jul 17, 2013

jqLite.on/bind supported eventNames seperated by spaces, but jqLite.off/unbind didn't.

@petebacondarwin
Copy link
Contributor

PR Checklist (Minor Bugfix)

  • Contributor signed CLA now or in the past (if you just signed, leave a comment here with your real name)
  • PR doesn't introduce new api
  • PR doesn't contain a breaking change
  • PR contains unit tests
  • PR contains e2e tests (if suitable)
  • PR contains documentation update (if suitable)
  • PR passes all tests on Travis (sanity)
  • PR passes all tests on ci.angularjs.org (cross-browser compatibility)
  • PR is rebased against recent master
  • PR is squashed into one commit per logical change
  • PR's commit messages are descriptive and allows us to autogenerate release notes (required commit message format)
  • All changes requested in review have been implemented

@pkozlowski-opensource
Copy link
Member

Jenkins-CI is happy: http://ci.angularjs.org/job/angular.js-pawel/122/

@pkozlowski-opensource
Copy link
Member

LGTM for what it's worth

@IgorMinar IgorMinar closed this in bdd4e98 Jul 31, 2013
@IgorMinar
Copy link
Contributor

thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajoslin @petebacondarwin @pkozlowski-opensource @IgorMinar