Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix($http): allow empty responses to be cached #3809

Closed
wants to merge 1 commit into from

Conversation

jankuca
Copy link
Contributor

@jankuca jankuca commented Aug 30, 2013

Fixes #3770

@@ -892,7 +892,7 @@ function $HttpProvider() {

if (cache) {
cachedResp = cache.get(url);
if (cachedResp) {
if (cachedResp || typeof cachedResp === 'string') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use isString(cachedResp)

@jankuca jankuca closed this in 8e48c4f Sep 2, 2013
jankuca added a commit that referenced this pull request Sep 2, 2013
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Sep 25, 2013
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty Template results in erroneous XHR when ngInclude is passed a function
2 participants