Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

angularjs1.2.0-rc.3. Priority of directives is reversed #4538

Closed
thetrevdev opened this issue Oct 19, 2013 · 5 comments
Closed

angularjs1.2.0-rc.3. Priority of directives is reversed #4538

thetrevdev opened this issue Oct 19, 2013 · 5 comments

Comments

@thetrevdev
Copy link

Using angularjs1.2.0-rc.3 the execution of directives based on priority seems reversed.
It is the opposite in previous versions. Is this only for compiling, should I not expect the linking functions to fire in the same order with higher priority first?

http://plnkr.co/edit/R1Fd8jxPk5FdR9aC1ke0?p=preview

@thetrevdev
Copy link
Author

Turns out it is related to
31f190d
#3558
Was confusing because the default link function is a post link. I would consider this a decent breaking change since it is common to just include a post link function. This change may be necessary for child transclusion but this definitely through me off.

@Narretz
Copy link
Contributor

Narretz commented Dec 19, 2013

Yeah, there's some info missing. In the commit it's marked as breaking change; not in the changelog though. In migration on the website it's mentioned, but it's not documented in the directive / compile docs.

@caitp
Copy link
Contributor

caitp commented Dec 19, 2013

It is in the changelog https://github.com/angular/angular.js/blob/master/CHANGELOG.md#breaking-changes-3 --- not sure which doc page it's in, but I recall seeing it briefly (maybe cryptically) mentioned

@Narretz
Copy link
Contributor

Narretz commented Dec 19, 2013

ah, right, I was looking for it in 1.2.0, not in one of the RCs

@btford
Copy link
Contributor

btford commented Dec 31, 2013

I'm going to close this since the ordering is working as expected.

I know how frustrating it is to not be able to find this kind of information quickly. If you have any suggestions on improving the way we communicate these changes in the future, I'd love to hear them. Better yet, a PR for the docs would be awesome. :)

@btford btford closed this as completed Dec 31, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants