Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ngIf will remain on android browser when angular 1.2.4 #5368

Closed
morlay opened this issue Dec 11, 2013 · 6 comments
Closed

ngIf will remain on android browser when angular 1.2.4 #5368

morlay opened this issue Dec 11, 2013 · 6 comments

Comments

@morlay
Copy link

morlay commented Dec 11, 2013

Hi everyone,

I use ngIf for draw like this

<div class="nav-drawer"
     ng-if="isShowNavDrawer"
     ng-swipe-left="hideNavDrawer()">

   <div class="nav-drawer-bg"
         ng-click="hideNavDrawer()"></div>

   <div class="nav-drawer-list"></div>

 </div>

image

It works well when angular < 1.2.4, but something wrong when I use angular 1.2.4, (with ngAnimate)
the DOM seems to remain and the console below:
image

I don't know why.
Anyone can help.

Thanks.

@ghost ghost assigned jeffbcross Dec 11, 2013
@jeffbcross
Copy link
Contributor

Hi @morlay, thanks for opening the issue. In order for us to be able to reproduce it, could you create a simplified plunkr demonstrating the problem?

@jeffbcross
Copy link
Contributor

This issue could be related to this commit that landed in 1.2.4: b0972a2

@morlay
Copy link
Author

morlay commented Dec 12, 2013

Hi @jeffbcross,

Thanks for your reply.

I write it on http://plnkr.co/edit/GolBHO

then we can use it like this.

click the button to show the drawer,
and click the backgroud or swipe-left to hide the drawer.

of course it works well on desktop browser,

but there is something wrong on android (4.1.2/4.2.2) browser (not chrome for android, I use cordova for app, so need to make sure it works well on webview).
and it seems that ngIf DOM node not to be removed.

qq20131212101607

and, it will works well again when let angular < 1.2.4.
Thanks.

@matsko
Copy link
Contributor

matsko commented Dec 18, 2013

This may be related to: #5241 and this should fix it matsko@7e09adf

@matsko
Copy link
Contributor

matsko commented Dec 20, 2013

@morlay please try using master or 1.2.6 tomorrow to see if it works.

@morlay
Copy link
Author

morlay commented Dec 20, 2013

Thanks a lot.
It works well again when angular 1.2.6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants