This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
bug(mocks): Correctly calls workFn with "this". #6102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the workFn is called with the implied, global "this" instead of the current context as it should be. See this bin for the problem and suggested solution: http://jsbin.com/EDohOlih/1/edit
|
oops.. I'll get this in tonight. any chance you can add a test? |
IgorMinar
pushed a commit
to IgorMinar/angular.js
that referenced
this pull request
Feb 4, 2014
…set to the current spec Currently when a function is injected inside of a test we set the context to undefined which is a bug. Closes angular#6102
|
I think your patch is not quite correct. I amended it and added a test. |
|
Ah, well if you're going to change it to Thanks for adding that test for me! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the workFn is called with the implied, global "this" instead of the current context as it should be.
See this bin for the problem and suggested solution:
http://jsbin.com/EDohOlih/1/edit