This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Jqlite data leak #7966
Closed
Jqlite data leak #7966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an element contains two "element" transcludes then the initial clone consists of only comment nodes. The concern was that this meant that the transclude scopes would not be cleaned up. But it turns out that in the case that there are only comments then the scope is never attached to anything so we don't need to worry about cleaning it up. Later if a concrete element is created as part of the transclude then these elements will have destroy handlers.
We were attaching handlers to comment nodes when setting up bound transclusion functions. But we don't clean up comments and text nodes when deallocating so there was a memory leak. Closes angular#7913
Calling `jqLite.data()` on a disallowed node type caused an empty object to be added to the cache. This could lead to memory leaks since we no longer clean up such node types when they are removed from the DOM.
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
ckknight
pushed a commit
to ckknight/angular.js
that referenced
this pull request
Jul 16, 2014
Calling `jqLite.data()` on a disallowed node type caused an empty object to be added to the cache. This could lead to memory leaks since we no longer clean up such node types when they are removed from the DOM. Closes angular#7966
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sits on top of #7942 so only the last commit is relevant here while the previous PR is not merged into master.