This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(httpBackend): IE undefined response in legacy standards mode #4761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 2, 2013 16:15
Fixes issue #4738. IE10 using IE8 document standards mode has responseType but response in undefined, responseText has a value in this scenario. Solution is to try and fallback to responseText if reponse is empty.
Fixes issue #4738. If response is undefined fallback to responseText. Simplified over just amending previous entry.
|
Have you checked that this change doesn't break real instances of IE8/9? Also it would need a unit test. |
|
I have tested in real instances of IE8 & 9 and cannot see any ill effects, response is undefined in browsers that don't support it so the or conditional takes care of that by falling back to responseText. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #4738. IE10 using IE8 document standards mode has
responseType but response in undefined, responseText has a value in this
scenario.
Solution is to try and fallback to responseText if reponse is empty.