Change NgClass selector from [class] to [ng-class] #3498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
force-pushed
the
class_to_ngclass
branch
2 times, most recently
from
ecc8e0d to
0fa2ab1
Compare
BREAKING CHANGE: The selector for the CSSClass directive was changed from [class] to [ng-class]. The directive itself was renamed from CSSClass to NgClass
naomiblack
added
the
action: review
mhevery
added
pr_state: LGTM
action: merge
| lifecycle: [LifecycleEvent.onCheck, LifecycleEvent.onDestroy], | ||
| properties: ['rawClass: class'] | ||
| properties: ['rawClass: ng-class'] |
There was a problem hiding this comment.
per our discussion yesterday this needs to bind both the class and ng-class
example: <div class="foo" ng-class="exp">
In this case we have to preserve foo so the binding should be.
properties: ['ngClass: ng-class', 'explicitClass: class' ]
We then have to merge the properties in explicitClass with that of ngClass
(You can merge this PR as is, and follow up with another PR)
mhevery
added
pr_state: LGTM
action: merge
|
Please merge this PR, and then send a follow up PR to fix #3498 (comment) |
goderbauer
pushed a commit
to goderbauer/angular
that referenced
this pull request
Aug 15, 2015
BREAKING CHANGE: The selector for the CSSClass directive was changed from [class] to [ng-class]. The directive itself was renamed from CSSClass to NgClass Closes angular#3498
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.