Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sfx): Include ngHttp in SFX bundle #3933

Closed

Conversation

alfonso-presa
Copy link
Contributor

Seems ngHttp doesn't have it's own SFX bundle, but it doesn't seem to be included in angular2's SFX bundle neither.

I've added it in the angular2's SFX bundle as having it's own SFX bundle was causing some issues (see: #3898 and #3890).

Fixes: #3934

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Sep 1, 2015
@tbosch tbosch added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 11, 2015
@tbosch
Copy link
Contributor

tbosch commented Sep 11, 2015

@jeffbcross Is this correct?

@jeffbcross jeffbcross added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Sep 18, 2015
@mary-poppins
Copy link

Merging PR #3933 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-3933.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 18, 2015
@jeffbcross
Copy link
Contributor

Thanks @alfonso-presa, merging!

robwormald pushed a commit to robwormald/angular that referenced this pull request Sep 25, 2015
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Http module is no longer available through SFX builds in Alpha 36.
5 participants