-
Notifications
You must be signed in to change notification settings - Fork 25.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sfx): Include ngHttp in SFX bundle #3933
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
3c4cfe1
to
11a60a1
Compare
CLAs look good, thanks! |
11a60a1
to
5438750
Compare
@jeffbcross Is this correct? |
5438750
to
c29f3f0
Compare
Merging PR #3933 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-3933. |
Thanks @alfonso-presa, merging! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Seems ngHttp doesn't have it's own SFX bundle, but it doesn't seem to be included in angular2's SFX bundle neither.
I've added it in the angular2's SFX bundle as having it's own SFX bundle was causing some issues (see: #3898 and #3890).
Fixes: #3934