fix(forms): avoid issues with nulls checking on validation status and… #4338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxhub
added
the
action: review
| @@ -3,17 +3,17 @@ import {AbstractControl} from '../model'; | |||
| export class AbstractControlDirective { | |||
| get control(): AbstractControl { return null; } | |||
|
|
|||
| get value(): any { return this.control.value; } | |||
| get value(): any { return this.control != null ? this.control.value : null; } | |||
There was a problem hiding this comment.
could you use isPresent(this.control) instead?
|
Maybe you can add an integration test that fails without the fix? |
alxhub
force-pushed
the
forms-small-fixes
branch
2 times, most recently
from
d239ac3 to
ec20d17
Compare
|
Added an integration test, which does seem to pass. :) |
vsavkin
removed
the
action: review
|
Merging PR #4338 on behalf of @alxhub to branch presubmit-alxhub-pr-4338. |
mary-poppins
removed
the
action: merge
… other form states.
alxhub
force-pushed
the
forms-small-fixes
branch
from
ec20d17 to
31410bf
Compare
mary-poppins
removed
the
action: merge
|
Merging PR #4338 on behalf of @alxhub to branch presubmit-alxhub-pr-4338. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… other form states.