Transformers support input outputs #5080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsavkin
added
the
action: review
| @Component({selector: 'order-list-cmp'}) | ||
| @View({ | ||
| @Component({ | ||
| selector: 'order-list-cmp', | ||
| template: ` | ||
| <h1>Orders</h1> | ||
| <div *ng-for="#order of orders" [class.warning]="order.total > order.limit"> |
There was a problem hiding this comment.
While you are at it, feel free to add a timy little leading space :)
|
|
||
| bool _isOutputAnnotation(Annotation node) { | ||
| var id = node.name; | ||
| final name = id is PrefixedIdentifier ? '${id.identifier}' : '$id'; |
There was a problem hiding this comment.
Move this logic to a reusable method (or top-level function)
kegluneq
added
action: cleanup
vsavkin
force-pushed
the
transformers_support_input_outputs
branch
from
f7a9f38 to
2e8d2a9
Compare
vsavkin
force-pushed
the
transformers_support_input_outputs
branch
from
2e8d2a9 to
d7b6472
Compare
|
Merging PR #5080 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5080. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.