Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): package angular2_testing to prepare it for publishing #5682

Closed
wants to merge 1 commit into from

Conversation

juliemr
Copy link
Member

@juliemr juliemr commented Dec 8, 2015

No description provided.

@juliemr juliemr added the area: testing Issues related to Angular testing features, such as TestBed label Dec 8, 2015
@yjbanov
Copy link
Contributor

yjbanov commented Dec 8, 2015

LGTM if LGT Travis.

@yjbanov yjbanov added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 8, 2015
@juliemr juliemr force-pushed the dart-testing-distro branch from c44091e to c164958 Compare December 8, 2015 01:44
@juliemr
Copy link
Member Author

juliemr commented Dec 8, 2015

I added another task to make sure that LICENSE gets copied. I'm not thrilled with how this affects the gulpfile, but the code for other LICENSE copying is buried in the broccoli dart tree, so not easily reusable for the pure dart packages.

All owners for angular2 have been added as owners for https://pub.dartlang.org/packages/angular2_testing

@juliemr juliemr force-pushed the dart-testing-distro branch from c164958 to 083d588 Compare December 8, 2015 19:15
@juliemr juliemr force-pushed the dart-testing-distro branch from 083d588 to 0274993 Compare December 8, 2015 19:24
@juliemr juliemr removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 8, 2015
@juliemr
Copy link
Member Author

juliemr commented Dec 8, 2015

Travis is happy!

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Dec 9, 2015
@mary-poppins
Copy link

Merging PR #5682 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5682.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: testing Issues related to Angular testing features, such as TestBed cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants