Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bundles): remove SFX bundle #5712

Closed
wants to merge 1 commit into from
Closed

fix(bundles): remove SFX bundle #5712

wants to merge 1 commit into from

Conversation

pkozlowski-opensource
Copy link
Member

Closes #5665

BREAKING CHANGE:

The existing sfx bundle (angular2.sfx.dev.js) is replaced by UMD bundles:
angular2.umd.js and angular2.umd.dev.js. The new UMD bundles dont have
external dependencies (zone, reflect-metadata) pre-appended. Those
external dependencies can be easily loaded by including
external-dependencies.js bundle

@pkozlowski-opensource pkozlowski-opensource added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 8, 2015
@IgorMinar IgorMinar added this to the beta.0 milestone Dec 8, 2015
@IgorMinar
Copy link
Contributor

do you plan to rename external-dependencies to angular-polyfills.js in a separate commit? for documentation/changelog purposes it would be better to make that change first and then use the new name in the breaking change note.

@IgorMinar IgorMinar self-assigned this Dec 8, 2015
@pkozlowski-opensource
fix(bundles): remove SFX bundle
0b63073 
Closes angular#5665

BREAKING CHANGE:

The existing sfx bundle (angular2.sfx.dev.js) is replaced by UMD bundles:
angular2.umd.js and angular2.umd.dev.js. The new UMD bundles dont have
polyfills (zone.js, reflect-metadata) pre-appended. Those polyfills
can be easily loaded by including the angular-polyfills.js bundle.
@pkozlowski-opensource
Copy link
Member Author

@IgorMinar sent #5716 to rename external deps bundle and amended message of the commit from this PR. Now #5716 should land before this PR.

@IgorMinar
Copy link
Contributor

angular-polyfills.js in commit message should be renamed to angular2-polyfills.js. @jelbourn can you please make the change and land this? thanks!

@IgorMinar IgorMinar assigned jelbourn and unassigned IgorMinar Dec 8, 2015
@IgorMinar IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews pr_state: LGTM action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 8, 2015
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jelbourn jelbourn

Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
beta.0
Development

Successfully merging this pull request may close these issues.

Changes to the SFX bundle
4 participants
@pkozlowski-opensource @IgorMinar @jelbourn @googlebot