Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(perf): don’t use try/catch in production mode #8338

Closed
wants to merge 1 commit into from
Closed

fix(perf): don’t use try/catch in production mode #8338

wants to merge 1 commit into from

Conversation

tbosch
Copy link
Contributor

@tbosch tbosch commented Apr 29, 2016

No description provided.

@tbosch
fix(perf): don’t use try/catch in production mode
8b8df34 
The previous code that had `try/catch` statements in methods could not be optimized by Chrome. 

This change separates `AppView` (no `try/catch`) form `DebugAppView` (always `try/catch`). Our codegen will use `AppView` in production mode and `DebugAppView` in debug mode.
@tbosch
Copy link
Contributor Author

tbosch commented Apr 29, 2016

Reviewed in person with @mhevery

@tbosch tbosch closed this in b1a9e44 Apr 29, 2016
@tbosch tbosch deleted the prod_perf branch April 29, 2016 17:20
tbosch added a commit to tbosch/angular that referenced this pull request May 11, 2016
@tbosch
fix(perf): don’t use try/catch in production mode
8f7a70c 
The previous code that had `try/catch` statements in methods could not be optimized by Chrome.

This change separates `AppView` (no `try/catch`) form `DebugAppView` (always `try/catch`). Our codegen will use `AppView` in production mode and `DebugAppView` in debug mode.

Closes angular#8338
tbosch added a commit to tbosch/angular that referenced this pull request May 11, 2016
@tbosch
fix(perf): don’t use try/catch in production mode
6b1686f 
The previous code that had `try/catch` statements in methods could not be optimized by Chrome.

This change separates `AppView` (no `try/catch`) form `DebugAppView` (always `try/catch`). Our codegen will use `AppView` in production mode and `DebugAppView` in debug mode.

Closes angular#8338
tbosch added a commit to tbosch/angular that referenced this pull request May 18, 2016
@tbosch
fix(perf): don’t use try/catch in production mode
08e1883 
The previous code that had `try/catch` statements in methods could not be optimized by Chrome.

This change separates `AppView` (no `try/catch`) form `DebugAppView` (always `try/catch`). Our codegen will use `AppView` in production mode and `DebugAppView` in debug mode.

Closes angular#8338
tbosch added a commit to tbosch/angular that referenced this pull request May 19, 2016
@tbosch
fix(perf): don’t use try/catch in production mode
5d4827d 
The previous code that had `try/catch` statements in methods could not be optimized by Chrome.

This change separates `AppView` (no `try/catch`) form `DebugAppView` (always `try/catch`). Our codegen will use `AppView` in production mode and `DebugAppView` in debug mode.

Closes angular#8338
tbosch added a commit to tbosch/angular that referenced this pull request May 20, 2016
@tbosch
fix(perf): don’t use try/catch in production mode
e9e9821 
The previous code that had `try/catch` statements in methods could not be optimized by Chrome.

This change separates `AppView` (no `try/catch`) form `DebugAppView` (always `try/catch`). Our codegen will use `AppView` in production mode and `DebugAppView` in debug mode.

Closes angular#8338
tbosch added a commit to tbosch/angular that referenced this pull request May 20, 2016
@tbosch
fix(perf): don’t use try/catch in production mode
4f9bf85 
The previous code that had `try/catch` statements in methods could not be optimized by Chrome.

This change separates `AppView` (no `try/catch`) form `DebugAppView` (always `try/catch`). Our codegen will use `AppView` in production mode and `DebugAppView` in debug mode.

Closes angular#8338
tbosch added a commit to tbosch/angular that referenced this pull request May 24, 2016
@tbosch
fix(perf): don’t use try/catch in production mode
1503b3a 
The previous code that had `try/catch` statements in methods could not be optimized by Chrome.

This change separates `AppView` (no `try/catch`) form `DebugAppView` (always `try/catch`). Our codegen will use `AppView` in production mode and `DebugAppView` in debug mode.

Closes angular#8338
tbosch added a commit to tbosch/angular that referenced this pull request May 26, 2016
@tbosch
fix(perf): don’t use try/catch in production mode
35db765 
The previous code that had `try/catch` statements in methods could not be optimized by Chrome.

This change separates `AppView` (no `try/catch`) form `DebugAppView` (always `try/catch`). Our codegen will use `AppView` in production mode and `DebugAppView` in debug mode.

Closes angular#8338
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbosch @googlebot