Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshotChanges does not inherit type of list/object #1523

Closed
iNViTiON opened this issue Mar 23, 2018 · 1 comment
Closed

snapshotChanges does not inherit type of list/object #1523

iNViTiON opened this issue Mar 23, 2018 · 1 comment

Comments

@iNViTiON
Copy link

Version info

**Angular: 5.2.9 **

Firebase: 4.12.0

AngularFire: 5.0.0-rc.6

The Problem

AngularFireList and AngularFireObject has a generic T that is not inherited to all of it's members, such as snapshotChanges.

The Fix

Need two PR to solve this. One to this project and another to firebase-js-sdk. Submitted here -> firebase/firebase-js-sdk#590

This issue refer and extend to issue1214

#1214
@iNViTiON iNViTiON mentioned this issue Mar 23, 2018
Closed
This was referenced May 14, 2018
Merged
Merged
@jamesdaniels
Copy link
Member

On master, will cut a @next release with this type additions shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamesdaniels @iNViTiON