Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix the instance cache logic, closes #2666 #2667

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Nov 18, 2020

It turns out that in lazy-loads and other sufficiently complex use-cases (e.g, not my sample app) ngc / webpack has now (6.1) decided that our injectables (such as AngularFirestore) can be duplicated.

While I was aware this could happen (lazy-loads for instance) and intended my instance cache to cover this and the HMR use-case, I had a bug in my fetch logic which would try to reinitialize the SDK instance even when the settings hadn't changed. Whoops. Explains why this wasn't working for HMR users as intended either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant