New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(afs): fixing the metadata in snapshotChanges and more #2670

Merged

jamesdaniels merged 3 commits into master from fix_afs_metadata

Nov 19, 2020

Member

jamesdaniels commented Nov 19, 2020

metadata updates weren't getting to the snapshotChanges on collections due to docChanges() not including metadata in the changes, even when you ask for it
pull spliceAndSlice from rxfire and use it in combination with distinctUntilChanged() to reduce unneeded change detection cycles
added some more stuff to my sample app


          fix(afs): fixing the metadata in snapshotChanges and more

71f3ec1

google-cla bot added the cla: yes label

jamesdaniels added 2 commits

November 19, 2020 01:02


          Working on more examples

2d7f085


          More sample work

22df77f

jamesdaniels merged commit d5dbe99 into master

jamesdaniels deleted the fix_afs_metadata branch

November 19, 2020 06:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels