Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compat/database): Zone should be destabilized on get #2923

Merged
merged 2 commits into from
Sep 7, 2021
Merged

fix(compat/database): Zone should be destabilized on get #2923

merged 2 commits into from
Sep 7, 2021

Conversation

jamesdaniels
Copy link
Member

  • Zone should be destabilized on get, it's tempting to let the fetch do it's thing but there are races (hence the magic 10ms timeout)
  • Subscribe wasn't happening in Angular zone 🤦‍♂️

@google-cla google-cla bot added the cla: yes label Sep 3, 2021
@jamesdaniels jamesdaniels changed the title Zone should be destablzed on doc/collection/group get Zone should be destabilized on doc/collection/group get Sep 3, 2021
@jamesdaniels jamesdaniels changed the title Zone should be destabilized on doc/collection/group get fix(compat/database): Zone should be destabilized on get Sep 7, 2021
@jamesdaniels jamesdaniels added this to the 7.0.4 milestone Sep 7, 2021
@jamesdaniels jamesdaniels merged commit c006da8 into master Sep 7, 2021
@jamesdaniels jamesdaniels deleted the getShouldBeZoneStable branch September 7, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bump: patch cla: yes
Projects
None yet
Milestone
7.0.4
Development

Successfully merging this pull request may close these issues.
1 participant
@jamesdaniels