Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added missing injector input signatures #3191

Merged
merged 1 commit into from
Apr 12, 2022
Merged

fix: added missing injector input signatures #3191

merged 1 commit into from
Apr 12, 2022

Conversation

dereekb
Copy link
Contributor

@dereekb dereekb commented Mar 25, 2022

Checklist

Description

Adding missing typings/signature to existing functions. Writeup is available in #3086.

jamesdaniels
jamesdaniels approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I'll make sure it's in the next release.

@jamesdaniels jamesdaniels merged commit 88796bc into angular:master Apr 12, 2022
@dereekb dereekb deleted the fix/injector branch April 12, 2022 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesdaniels jamesdaniels jamesdaniels approved these changes

Assignees
No one assigned
Labels
bump: patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dereekb @jamesdaniels