Skip to content

Commit

Permalink
fix(database): removed unused query option
Browse files Browse the repository at this point in the history
The docs mention that lists should be used for querying/filtering and
the query option is ignored by the object factory. The query option
should be removed so that it is no longer suggested by TypeScript-based
tools, etc.

Closes #706
  • Loading branch information
cartant authored and davideast committed Dec 25, 2016
1 parent b46eba6 commit 9cbc59b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
4 changes: 1 addition & 3 deletions src/database/firebase_object_factory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,11 @@ import { Observer } from 'rxjs/Observer';
import { observeOn } from 'rxjs/operator/observeOn';
import * as firebase from 'firebase';
import * as utils from '../utils';
import { Query } from '../interfaces';
import { observeQuery } from './query_observable';
import { FirebaseObjectFactoryOpts } from '../interfaces';

export function FirebaseObjectFactory (
absoluteUrlOrDbRef: string | firebase.database.Reference,
{ preserveSnapshot, query }: FirebaseObjectFactoryOpts = {}): FirebaseObjectObservable<any> {
{ preserveSnapshot }: FirebaseObjectFactoryOpts = {}): FirebaseObjectObservable<any> {

let ref: firebase.database.Reference;

Expand Down
3 changes: 1 addition & 2 deletions src/interfaces.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ export interface FirebaseListFactoryOpts {

export interface FirebaseObjectFactoryOpts {
preserveSnapshot?: boolean;
query?: Query
}


Expand All @@ -87,4 +86,4 @@ export enum QueryOptions {
EndAt
}

export type Primitive = number | string | boolean;
export type Primitive = number | string | boolean;

0 comments on commit 9cbc59b

Please sign in to comment.