Skip to content

Commit

Permalink
fix(): Removing errant old import. Updating build with latest namespa…
Browse files Browse the repository at this point in the history
…ce. Fixing import for main @firebase/app. This resolves failing tests.
  • Loading branch information
myspivey authored and davideast committed Dec 26, 2017
1 parent 7ec51b2 commit a13bf9b
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 16 deletions.
2 changes: 1 addition & 1 deletion src/core/firebase.app.module.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { InjectionToken, } from '@angular/core';
import { FirebaseAppConfig } from './';
import { firebase } from '@firebase/app';
import firebase from '@firebase/app';

import { FirebaseApp as FBApp } from '@firebase/app-types';
import { FirebaseAuth } from '@firebase/auth-types';
Expand Down
1 change: 0 additions & 1 deletion src/database-deprecated/firebase_list_factory.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import * as database from '@firebase/database-types';
import { ZoneScheduler } from 'angularfire2';
import * as utils from './utils';
import 'firebase/database';
import { AFUnwrappedDataSnapshot } from './interfaces';
import { FirebaseListObservable } from './firebase_list_observable';
import { Observer } from 'rxjs/Observer';
Expand Down
28 changes: 14 additions & 14 deletions tools/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@ const GLOBALS = {
'@angular/core': 'ng.core',
'@angular/compiler': 'ng.compiler',
'@angular/platform-browser': 'ng.platformBrowser',
'firebase/auth': 'firebase',
'firebase/app': 'firebase',
'firebase/database': 'firebase',
'firebase/firestore': 'firebase',
'firebase/storage': 'firebase',
'@firebase/auth': 'firebase',
'@firebase/app': 'firebase',
'@firebase/database': 'firebase',
'@firebase/firestore': 'firebase',
'@firebase/storage': 'firebase',
'rxjs/scheduler/queue': 'Rx.Scheduler',
'@angular/core/testing': 'ng.core.testing',
'angularfire2': 'angularfire2',
Expand Down Expand Up @@ -123,8 +123,8 @@ const TSC_TEST_ARGS = [`-p`, `${process.cwd()}/src/tsconfig-test.json`];

/**
* Create an Observable of a spawned child process.
* @param {string} command
* @param {string[]} args
* @param {string} command
* @param {string[]} args
*/
function spawnObservable(command, args) {
return Observable.create(observer => {
Expand All @@ -151,8 +151,8 @@ function generateBundle(entry, { dest, globals, moduleName }) {

/**
* Create a UMD bundle given a module name.
* @param {string} name
* @param {Object} globals
* @param {string} name
* @param {Object} globals
*/
function createUmd(name, globals) {
// core module is angularfire2 the rest are angularfire2.feature
Expand All @@ -177,15 +177,15 @@ function createTestUmd(globals) {

/**
* Get the file path of the src package.json for a module
* @param {string} moduleName
* @param {string} moduleName
*/
function getSrcPackageFile(moduleName) {
return SRC_PKG_PATHS[moduleName];
}

/**
* Get the file path of the dist package.json for a module
* @param {string} moduleName
* @param {string} moduleName
*/
function getDestPackageFile(moduleName) {
return DEST_PKG_PATHS[moduleName];
Expand All @@ -194,8 +194,8 @@ function getDestPackageFile(moduleName) {
/**
* Create an observable of package.json dependency version replacements.
* This keeps the dependency versions across each package in sync.
* @param {string} name
* @param {Object} versions
* @param {string} name
* @param {Object} versions
*/
function replaceVersionsObservable(name, versions) {
return Observable.create((observer) => {
Expand Down Expand Up @@ -287,7 +287,7 @@ function buildModule(name, globals) {

/**
* Create an observable of module build status. This method builds
* @param {Object} globals
* @param {Object} globals
*/
function buildModules(globals) {
const core$ = buildModule('core', globals);
Expand Down

0 comments on commit a13bf9b

Please sign in to comment.