-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(auth): make sure onAuth runs in Angular zone
There is one place in auth that takes a promise from Firebase, the promise from getRedirectResult(), and creates an observable from it. Since Firebase is using their own Promise implementation, the Promise and its derived observable were running in the root zone instead of the Angular zone, causing onAuth changes to not immediately be propagated to the view. By casting the firebase Promise to a zone-patched Promise, the observable now runs in the Angular zone. Fixes #231
- Loading branch information
1 parent
68d711e
commit d9a6ae7
Showing
1 changed file
with
9 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters