-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): only import typing from zone.js #1599
Conversation
If I genereta ionic start coference, i get the same error when install de plugin |
Changing the import did not work for me. I had to remove the complete line to make my application work again (using Ionic) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not work if use firebase and ionic conference example
@pookdeveloper , could you provide a reproduce repo? |
@JiaLiPassion Hellou I only generate the ionic start with template conference, and then install firebase and make the change to
try those steps and comment, thanks |
@pookdeveloper , after install
It will not be loaded into bundle, could you try this zip https://github.com/angular/angularfire2/files/1977627/dist.zip to replace |
Thanks for the fix |
This zip did not work for me or fix it |
I'm seeing complaints that #1599 didn't go far enough. It seems the Zone calls are fine being implicitly loaded; so let's drop the import completely.
Checklist
yarn install
,yarn test
run successfully? yes (yes/no; required)Description
Should only
import {} from 'zone.js'
to import typing, but not importzone.js
again, otherwise it will reportZone is already loaded
error.Code sample
@jamesdaniels , please review, thank you.