Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): only import typing from zone.js #1599

Merged
merged 1 commit into from
May 9, 2018

Conversation

JiaLiPassion
Copy link
Contributor

@JiaLiPassion JiaLiPassion commented May 5, 2018

Checklist

  • Issue number for this PR: Error: Zone already loaded. #1597 (required)
  • Docs included?: no (yes/no; required for all API/functional changes)
  • Test units included?: no (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? yes (yes/no; required)

Description

Should only import {} from 'zone.js' to import typing, but not import zone.js again, otherwise it will report Zone is already loaded error.

Code sample

@jamesdaniels , please review, thank you.

@pookdeveloper
Copy link

If I genereta ionic start coference, i get the same error when install de plugin

@paulstelzer
Copy link
Contributor

paulstelzer commented May 7, 2018

Changing the import did not work for me. I had to remove the complete line to make my application work again (using Ionic)

Copy link

@pookdeveloper pookdeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not work if use firebase and ionic conference example

@JiaLiPassion
Copy link
Contributor Author

@pookdeveloper , could you provide a reproduce repo?

@pookdeveloper
Copy link

@JiaLiPassion Hellou I only generate the ionic start with template conference, and then install firebase and make the change to

import {} from 'zone.js';

try those steps and comment, thanks

@JiaLiPassion
Copy link
Contributor Author

@pookdeveloper , after install angularfire2 from npm, even you change the src to

import {} from 'zone.js';

It will not be loaded into bundle, could you try this zip https://github.com/angular/angularfire2/files/1977627/dist.zip to replace node_modules/angularfire2/

@jamesdaniels jamesdaniels merged commit 5694e7c into angular:master May 9, 2018
@jamesdaniels
Copy link
Member

Thanks for the fix

@LRonHubs
Copy link

This zip did not work for me or fix it

jamesdaniels added a commit that referenced this pull request May 12, 2018
I'm seeing complaints that #1599 didn't go far enough. It seems the Zone calls are fine being implicitly loaded; so let's drop the import completely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants