Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(firestore): .get() Observable #1824

Merged
merged 3 commits into from
Aug 21, 2018
Merged

feat(firestore): .get() Observable #1824

merged 3 commits into from
Aug 21, 2018

Conversation

davideast
Copy link
Member

@davideast davideast commented Aug 21, 2018 •
edited
Loading

.get() observable!

constructor(afs: AngularFirestore) {
  const items$ = afs.collection('items').get({ source: 'server' });
}

@davideast davideast changed the title feat(firestore): .get( Observable feat(firestore): .get() Observable Aug 21, 2018
@davideast davideast requested a review from jamesdaniels August 21, 2018 17:51
jamesdaniels
jamesdaniels approved these changes Aug 21, 2018
View reviewed changes
Copy link
Member

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, we should follow up with docs + tests though.

@jamesdaniels
Copy link
Member

@davideast want to take point on a similar API for RTDB, wrapping once?

@jamesdaniels jamesdaniels merged commit 9f34be8 into angular:master Aug 21, 2018
sulco pushed a commit to sulco/angularfire2 that referenced this pull request Sep 3, 2018
@davideast @sulco
feat(firestore): get Observable (angular#1824)
e13c7aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesdaniels jamesdaniels jamesdaniels approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davideast @jamesdaniels @googlebot