Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): fix for zone issues on storage #1835

Merged
merged 1 commit into from
Aug 24, 2018
Merged

fix(storage): fix for zone issues on storage #1835

merged 1 commit into from
Aug 24, 2018

Conversation

jamesdaniels
Copy link
Member

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Fix for the timers that start in Storage RequestInfo.

Code sample

@jamesdaniels jamesdaniels requested a review from davideast August 23, 2018 23:13
davideast
davideast approved these changes Aug 24, 2018
View reviewed changes
Copy link
Member

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davideast davideast merged commit 441607a into master Aug 24, 2018
@davideast davideast deleted the storage_fix branch August 24, 2018 16:03
sulco pushed a commit to sulco/angularfire2 that referenced this pull request Sep 3, 2018
@jamesdaniels @sulco
fix(storage): fix for zone issues on storage (angular#1835)
f20919b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davideast davideast davideast approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesdaniels @davideast @googlebot