Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes, mostly ng10 and FCM regressions #2522

Merged
merged 5 commits into from
Jun 26, 2020
Merged

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Jun 25, 2020

  • Use navigator serviceWorker for notifications, as FCM seems to be having trouble with RXJS & Angular
  • Use more of the registerX hacks to work around ngcc tree-shaking. Tapping also seems to help, race condition maybe?
  • Port the sample app to NG 10
  • Add all the firebase packages to the Universal externals, having a bunch of problems with that
  • Experimenting with overriding the legacy packaging choices of the JS SDK with ngcc.config in the sample app, should add to the ng add schematic if it proves workable
  • FCM broke in a minor at some point, getToken now prompts for permission; work around this break for now
  • Firebase Auth seems to be firing an initial null more often now, add the getRedirectResult work-around for now
  • Firebase Auth is now failing to load in the server environment entirely, work around by returning of(null)
  • Storage is not firing the last snapshot state before completion, making this API difficult to work with, fixed

@jamesdaniels jamesdaniels marked this pull request as ready for review June 26, 2020 21:28
@jamesdaniels jamesdaniels merged commit 7cb6c03 into master Jun 26, 2020
@jamesdaniels jamesdaniels deleted the various_fixes_603 branch June 26, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants