Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sourcemaps referencing non-existent ts files #293

Closed
dmastag opened this issue Jun 27, 2016 · 1 comment
Closed

sourcemaps referencing non-existent ts files #293

dmastag opened this issue Jun 27, 2016 · 1 comment
Assignees
@jeffbcross
Labels
comp: build/pipeline Help Wanted! type: bug
Milestone
Beta.3

Comments

@dmastag
Copy link
Contributor

dmastag commented Jun 27, 2016 •
edited
Loading

As explained in #142 some ts files are shown as non existent.
These files are not downloaded if using
npm install angularfire2

Am I installing it incorrectly?
@jeffbcross jeffbcross changed the title ts files not existent on npm install angularfire2 sourcemaps referencing non-existent ts files Jun 30, 2016
@jeffbcross
Copy link
Contributor

The TS files should not be in the project, and should not be referenced by the sourcemap. It appears there's a bug in the sourcemap configuration.

@jeffbcross jeffbcross added this to the Beta.3 milestone Jun 30, 2016
@jeffbcross jeffbcross self-assigned this Jun 30, 2016
jeffbcross added a commit to jeffbcross/angularfire2 that referenced this issue Jul 1, 2016
@jeffbcross
fix: inline sources in source maps included with npm distribution
79e9291 
Fixes angular#293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffbcross jeffbcross

Labels
comp: build/pipeline Help Wanted! type: bug
Projects
None yet
Milestone
Beta.3
Development

No branches or pull requests
2 participants
@jeffbcross @dmastag