Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move firebase out of peerDeps #311

Closed
jeffbcross opened this issue Jun 30, 2016 · 0 comments
Closed

chore: move firebase out of peerDeps #311

jeffbcross opened this issue Jun 30, 2016 · 0 comments
Assignees
@jeffbcross
Labels
comp: build/pipeline type: chore
Milestone
Beta.3

Comments

@jeffbcross
Copy link
Contributor

The Firebase SDK should be installed automatically when installing AngularFire2, since users may not always use it directly. Since most users installing angularfire2 will already have Angular and RxJS installed (my guess), this would simplify the installation process and not have any peer dependency errors.
@jeffbcross jeffbcross added this to the Beta.3 milestone Jun 30, 2016
@jeffbcross jeffbcross self-assigned this Jun 30, 2016
jeffbcross added a commit to jeffbcross/angularfire2 that referenced this issue Jun 30, 2016
@jeffbcross
chore(package): make firebase a dependency instead of peerDep in publ…
02cf7e1 
…ished package

Fixes angular#311
jeffbcross added a commit to jeffbcross/angularfire2 that referenced this issue Jul 1, 2016
@jeffbcross
chore(package): make firebase a dependency instead of peerDep in publ…
f552d41 
…ished package

Fixes angular#311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffbcross jeffbcross

Labels
comp: build/pipeline type: chore
Projects
None yet
Milestone
Beta.3
Development

No branches or pull requests
1 participant
@jeffbcross