Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintended side effect in our cancel functions (we may unintentionally remove observers attached via other means) #443

Closed
katowulf opened this issue Aug 17, 2016 · 0 comments
Milestone

Comments

@katowulf
Copy link
Contributor

Both firebase_list_factory.js and firebase_object_factory.js return a cancel function which internally calls ref.off(); However, since no arguments are provided, this has the side effect of terminating any other listeners attached to that database path and could lead to some unexpected and hard to debug behaviors.

We should change this to include the event and callback function in the calls to off().

katowulf added a commit to katowulf/angularfire2 that referenced this issue Aug 24, 2016
davideast pushed a commit that referenced this issue Aug 24, 2016
@davideast davideast added this to the beta.5 milestone Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants