Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): removing the new peers, unneeded and confusing to existing users #2095

Merged
merged 4 commits into from
Jul 8, 2019

Conversation

jamesdaniels
Copy link
Member

Checklist

Description

The new peerDependencies included for the schematics aren't necessary to include in the published package and the peer warnings are confusing, especially for yarn users.

The dependencies on fuzzy, inquirer, and the @angular-devkit/* are taken care of if the developer uses ng add @angular/fire (4ed421c) and are only used in that step.

The firebase-tools dependency doesn't have to be expressed as a peer, as if you try to do ng deploy without firebase-tools installed you get a good error:

Error when trying to deploy: 
Cannot find module 'firebase-tools'

@jamesdaniels
Copy link
Member Author

This is minor enough and the tests are green, cutting as 5.2.1.

@jamesdaniels jamesdaniels requested a review from jhuleatt June 23, 2019 01:10
Copy link
Collaborator

@jhuleatt jhuleatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this, LGTM

@jamesdaniels
Copy link
Member Author

@jhuleatt no worries, I had already cut since it was straight forward enough and passed smoke tests. Thanks for the green light for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants