From 3ad6ff09463ee3275c679d4b65824194dfdc44c6 Mon Sep 17 00:00:00 2001
From: Will Howell <will.s.howell@gmail.com>
Date: Fri, 17 Mar 2017 16:26:09 -0400
Subject: [PATCH] fix(button): persist theme color of button when leaving hover
 state (#3629)

For all buttons that need the focus overlay to be visible on on focus, that is already covered in `_button-base.scss`.

For flat or icon buttons that need the focus overlay to be visible on hover, that is already covered in `button.scss`.

All disabled buttons should always hide the focus overlay.
---
 src/lib/button/_button-theme.scss | 17 ++++++++---------
 src/lib/button/button.scss        |  6 ------
 2 files changed, 8 insertions(+), 15 deletions(-)

diff --git a/src/lib/button/_button-theme.scss b/src/lib/button/_button-theme.scss
index c77f5dbf202d..cbd41be089cc 100644
--- a/src/lib/button/_button-theme.scss
+++ b/src/lib/button/_button-theme.scss
@@ -18,6 +18,10 @@
   &.mat-warn .mat-button-focus-overlay {
     background-color: mat-color($warn, 0.12);
   }
+
+  &[disabled] .mat-button-focus-overlay {
+    background-color: transparent;
+  }
 }
 
 // Applies a property to an md-button element for each of the supported palettes.
@@ -54,20 +58,15 @@
   $foreground: map-get($theme, foreground);
 
   .mat-button, .mat-icon-button, .mat-raised-button, .mat-fab, .mat-mini-fab {
-    &.cdk-keyboard-focused {
-      @include _mat-button-focus-color($theme);
-    }
+    // Appy color to focus overlay.
+    // The focus overlay will be visible when any button type is focused or when
+    // flat buttons or icon buttons are hovered.
+    @include _mat-button-focus-color($theme);
   }
 
   .mat-button, .mat-icon-button {
     @include _mat-button-theme-color($theme, 'color');
     background: transparent;
-
-    // Only flat buttons and icon buttons (not raised or fabs) have a hover style.
-    // Use the same visual treatment for hover as for focus.
-    &:hover {
-      @include _mat-button-focus-color($theme);
-    }
   }
 
   .mat-raised-button, .mat-fab, .mat-mini-fab {
diff --git a/src/lib/button/button.scss b/src/lib/button/button.scss
index 900e08136a1d..04b68cec7b4c 100644
--- a/src/lib/button/button.scss
+++ b/src/lib/button/button.scss
@@ -14,12 +14,6 @@
       opacity: 1;
     }
   }
-
-  &[disabled]:hover {
-    &.mat-primary, &.mat-accent, &.mat-warn, .mat-button-focus-overlay {
-      background-color: transparent;
-    }
-  }
 }
 
 .mat-raised-button {